Apps My open-source android project

[knight74]

Hi All!
I developing open source project now, and ask anybody to make code-review (java, structure classes, layouts, libraries, etc) to make my project better. I think it's better make now, when I just started, when I can fix mistakes more easy.

My project here:
https://github.com/amanita-main/JustRun
Thank you for help

 

[Astr4y4L]

Hi All!
I developing open source project now, and ask anybody to make code-review (java, structure classes, layouts, libraries, etc) to make my project better. I think it's better make now, when I just started, when I can fix mistakes more easy.

My project here:
https://github.com/amanita-main/JustRun
Thank you for help

Well Hi There,
I've taken a quick look at your git-hub link above but your basically asking people to review your Source without any Mark-up about what the Code / App is supposed to do...

If we Have No Project Description here or on github then it's Very hard to make any suggestions on features or code.

SO MY ADVISE :
Please update your post here to describe the purpose , Vision and Scope of your Project,
And Update github with the correct README.md

and Some fine folks out there may even be willing to Gradle Brew your Project or run it in Android Studio or what ever but as it is,
There's A Lot of random code with no description so I will not be Git Cloning it any time soon..
but I'll keep an Eye out for when you've updated it .

thanks for sharing !


Astr4y4L
Team_Astr4y4L

 

[Deleted User]

^--- Harsh but true. Nobody is really going to have the inclination or time to review that lot of code, even if there was some documentation for it.

What I would say is that you have pretty much no unit tests. That's a red flag for me right there. You should build up a comprehensive set of unit/regression tests to ensure good code quality.

 

[knight74]

Thanks for answers. I added readme.md, some amount code comments.
And going to learn about making unit tests and where I should to use it.