Apps Need help with saving the states of checkboxes

[SCB360]

I'm trying to save the selections of checkboxes when I open the app or go to a different activity, it is a simple program that shows a list of countries and flags that you can set as favorites, I just cannot see where I've gone wrong here:

public class MyAdapter extends ArrayAdapter<String> {

String[] names;
int[] flags;
Context mContext;

public MyAdapter(Context context, String[] countryNames, int[] countryFlags, String[] countryDetails) {
super(context, R.layout.listview_item);
this.names = countryNames;
this.flags = countryFlags;
this.mContext = context;
}

[USER=1021285]@override[/USER]
public int getCount() {
   return names.length;
}

@NonNull
[USER=1021285]@override[/USER]
public View getView(int position, View convertView, ViewGroup parent) {
   ViewHolder mViewHolder = new ViewHolder();
   final SharedPreferences sp = mContext.getSharedPreferences("FreshStart", 0);
   boolean shouldBeChecked = sp.getBoolean(names[position], false);

if (convertView == null) {
   LayoutInflater mInflater = (LayoutInflater) mContext.
           getSystemService(Context.LAYOUT_INFLATER_SERVICE);
   convertView = mInflater.inflate(R.layout.listview_item, parent, false);
   mViewHolder.mFlag = (ImageView) convertView.findViewById(R.id.imageView);
   mViewHolder.mName = (TextView) convertView.findViewById(R.id.textView);
   mViewHolder.mCheckBox = convertView.findViewById(R.id.check_Box);

} else {
   mViewHolder = (ViewHolder) convertView.getTag();
}
mContext.getSharedPreferences("FreshStart",0);
mViewHolder.mFlag.setImageResource(flags[position]);
mViewHolder.mName.setText(names[position]);

mViewHolder.mCheckBox.setTag(names[position]);
convertView.setTag(mViewHolder);
mViewHolder.mCheckBox.setChecked(shouldBeChecked);


mViewHolder.mCheckBox.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
   public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
       sp.setBoolean(names[position], isChecked);
       buttonView.setSelected(isChecked);
       if (isChecked)
           Toast.makeText(mContext, "Saved as Favorite", Toast.LENGTH_SHORT).show();
       else
           Toast.makeText(mContext, "No Longer set as Favorite", Toast.LENGTH_SHORT).show();

   }
});

return convertView;
}

static class ViewHolder {
ImageView mFlag;
TextView mName;
CheckBox mCheckBox;
}

 

[Deleted User]

The problem is, there is no code to save the state of the checkboxes.

 

[SCB360]

is that not what the Boolean is doing? It seems to be line 49 thats a problem

 

[Deleted User]

Ah, apologies, you're using SharedPreferences.
You need some code in there to commit the changes, otherwise they're not saved.

https://developer.android.com/training/data-storage/shared-preferences
https://developer.android.com/reference/android/content/SharedPreferences.Editor

However, when the view is recreated, you also need some code which retrieves the saved values, and restores all the checkboxes to their correct values.

 

[SCB360]

hmm ok, I'll take a look at that, aside from this, as a quick look is there anything in my code that doesn't seem right?

 

[Deleted User]

Only that you might want to look at RecyclerView, which has the ViewHolder pattern baked into it.

 

[SCB360]

yea that actually was what I was going to next once I got this up and functioning

 

[SCB360]

Hmm, I cannot work out where to put these