• After 15+ years, we've made a big change: Android Forums is now Early Bird Club. Learn more here.

Apps App stalls depending on sharedpreferences selected

S

saintratchet

Lurker
Hi,

I'm developing a version of the Mastermind game as an Android app and I've hit a bit of a wall. I have the game coded out and I have an options menu set up using Shared Preferences but when certain options are selected and I click on play, the app stops working and cuts to a black screen accepting no new input.
The game works perfectly fine when I have selected the option for a 4 Peg code with 4, 5 or 6 colours but when I select a 6 Peg code it only works when I have selected 6 colours. When I select a 6 Peg code with 4 or 5 colours the app stalls as mentioned above.
Any help with this at all would be greatly appreciated, I've been stuck on this for a few days and can't wrap my head around what could be causing the issue.

Here is my onCreate method that takes in the preferences and loads up the necessary button images.
Code: 
MediaPlayer mp;
int codeLength;
int[] code = {0};
ImageButton orangeButton, purpleButton;
private static final String TAG = MainActivity.class.getSimpleName();

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    SharedPreferences SP = PreferenceManager.getDefaultSharedPreferences(getBaseContext());   // SHARED PREFERENCES
    boolean boo = SP.getBoolean("duplicates", false);
    String str = SP.getString("pegs", "1");
    String colour = SP.getString("colours", "4");
    Log.w(TAG, "Peg number is: " + str + "and Colour number is: " + colour);

    if(str.equalsIgnoreCase("1")){
        setContentView(R.layout.activity_main);
    }
    else if(str.equalsIgnoreCase("2"))
        setContentView(R.layout.game_6);
    else
        setContentView(R.layout.activity_main_test);

    ImageButton redButton = (ImageButton) findViewById(R.id.redPeg);
    redButton.setOnClickListener(this);

    ImageButton greenButton = (ImageButton) findViewById(R.id.greenPeg);
    greenButton.setOnClickListener(this);

    ImageButton blueButton = (ImageButton) findViewById(R.id.bluePeg);
    blueButton.setOnClickListener(this);

    ImageButton yellowButton = (ImageButton) findViewById(R.id.yellowPeg);
    yellowButton.setOnClickListener(this);

    ImageButton codeButton = (ImageButton) findViewById(R.id.CodeButton);
    codeButton.setOnClickListener(this);

    Button lineButton = (Button) findViewById(R.id.LineButton);
    lineButton.setOnClickListener(this);

    purpleButton = (ImageButton) findViewById(R.id.purplePeg);
    purpleButton.setOnClickListener(this);

    orangeButton = (ImageButton) findViewById(R.id.orangePeg);
    orangeButton.setOnClickListener(this);

    setColourPegs(Integer.parseInt(colour));

    Peg.pegFalse();

    Code.setDuplicates(boo);


    if(str.equalsIgnoreCase("2"))
        codeLength = 6;
    else
        codeLength = 4;


    Code.setColours(Integer.parseInt(colour));

    Code.setCodeLength(codeLength);
    Check.setCodeLength(codeLength);

    code = Code.Generate();
}

And here is the setColours method

Code: 
public void setColourPegs(int colour){

    if(colour == 5){
        purpleButton.setBackgroundColor(Color.parseColor("#ffffff"));
        purpleButton.setImageResource(R.drawable.purple_peg2);
    }
    else if (colour == 6){
        purpleButton.setBackgroundColor(Color.parseColor("#ffffff"));
        purpleButton.setImageResource(R.drawable.purple_peg2);

        orangeButton.setBackgroundColor(Color.parseColor("#ffffff"));
        orangeButton.setImageResource(R.drawable.orange_peg2);
    }
}

Like I said, any help at all would be appreciated and if anyone needs to see any other classes or methods please just ask and I'd be more than happy to help.
Thanks.
 
When you say the app "stops working", does it crash?
Do you get any errors in the Logcat window?

Have you tried setting a breakpoint in method setColourPegs() and step through the code to see what happens?
 
Hi, it's not necessarily a crash. Just more the app moves to a new screen but the screen is blank and then the app freezes, I guess would be the best way to describe it. I can't do anything when it freezes other than press the home button.

I don't get any errors in the log window and just from the fact that it works for 4 Pegs but not 6 Pegs is really whats confusing me.

Haven't tried a breakpoint yet (still pretty new to Android), but I will try and give it a go. I set up a log message to ensure that I was getting the correct values for colour and str from preferences and they were both correct when I ran it.
 
I was just playing with the app there and I got a new error message in the logcat that I hadn't got previously. I selected 6 Pegs and 4 colours and instead of pressing play straight away, I read the how to play section of the app.
So about 10 seconds after clicking the options, I pressed play and the screen loaded up properly :)

The new logcat message displayed was: "Skipped 95 frames! The application may be doing too much work on its main thread."

So I'm guessing this is the problem, though I don't know why that would explain the app having difficulties in loading 6 Pegs 4 colours and not 6 Pegs 6 colours.
 
It would help if you showed the code you are using to handle the play button click.

I think that logcat message is a red herring. The Android runtime gets a bit paranoid about clogging up the main UI thread. My apps get that message all the time, but it doesn't seem to affect their operation.
 
Alright, heres onClick:
Code: 
public void onClick(View v) {

    int[] code = codeGenerator();


    Toast pieceToast;
    ImageButton imgBus;
    String buttonID;
    int resID;
    int z = 0;
    int[] pins;

    boolean b;
    boolean win;

    switch (v.getId()) {

        case R.id.redPeg:

            b = Full();
            if (b == false) {
                z = pegPosition();
                buttonID = "pegimage" + String.valueOf(z);
                resID = getResources().getIdentifier(buttonID, "id", getPackageName());
                imgBus = ((ImageButton) findViewById(resID));
                imgBus.setImageResource(R.drawable.red_peg_nobg);
                imgBus.setTag("1");
                Check.setPegCode(1);
            } else {
                pieceToast = Toast.makeText(getApplicationContext(), "Press the Check Button", Toast.LENGTH_SHORT);
                pieceToast.show();
            }
            break;

        case R.id.greenPeg:

            b = Full();
            if (b == false) {
                z = pegPosition();
                buttonID = "pegimage" + String.valueOf(z);
                // buttonID = position();
                resID = getResources().getIdentifier(buttonID, "id", getPackageName());
                imgBus = ((ImageButton) findViewById(resID));
                imgBus.setImageResource(R.drawable.green_peg2_nobg);
                imgBus.setTag("3");
                Check.setPegCode(3);
            } else {
                pieceToast = Toast.makeText(getApplicationContext(), "Press the Check Button", Toast.LENGTH_SHORT);
                pieceToast.show();
            }

            break;

        case R.id.bluePeg:

            b = Full();
            if (b == false) {
                z = pegPosition();
                buttonID = "pegimage" + String.valueOf(z);
                // buttonID = position();
                resID = getResources().getIdentifier(buttonID, "id", getPackageName());
                imgBus = ((ImageButton) findViewById(resID));
                imgBus.setImageResource(R.drawable.blue_peg2_nobg);
                imgBus.setTag("2");
                Check.setPegCode(2);
            } else {
                pieceToast = Toast.makeText(getApplicationContext(), "Press the Check Button", Toast.LENGTH_SHORT);
                pieceToast.show();
            }

            break;

        case R.id.yellowPeg:
            b = Full();
            if (b == false) {
                z = pegPosition();
                buttonID = "pegimage" + String.valueOf(z);
                // buttonID = position();
                resID = getResources().getIdentifier(buttonID, "id", getPackageName());
                imgBus = ((ImageButton) findViewById(resID));
                imgBus.setImageResource(R.drawable.yellow_peg2_nobg);
                imgBus.setTag("4");
                Check.setPegCode(4);
            } else {
                pieceToast = Toast.makeText(getApplicationContext(), "Press the Check Button", Toast.LENGTH_SHORT);
                pieceToast.show();
            }

            break;

        case R.id.purplePeg:
            b = Full();
            if (b == false) {
                z = pegPosition();
                buttonID = "pegimage" + String.valueOf(z);
                // buttonID = position();
                resID = getResources().getIdentifier(buttonID, "id", getPackageName());
                imgBus = ((ImageButton) findViewById(resID));
                imgBus.setImageResource(R.drawable.purple_peg2_nobg);
                imgBus.setTag("5");
                Check.setPegCode(5);
            } else {
                pieceToast = Toast.makeText(getApplicationContext(), "Press the Check Button", Toast.LENGTH_SHORT);
                pieceToast.show();
            }

            break;

        case R.id.orangePeg:
            b = Full();
            if (b == false) {
                z = pegPosition();
                buttonID = "pegimage" + String.valueOf(z);
                // buttonID = position();
                resID = getResources().getIdentifier(buttonID, "id", getPackageName());
                imgBus = ((ImageButton) findViewById(resID));
                imgBus.setImageResource(R.drawable.orange_peg2_nobg);
                imgBus.setTag("6");
                Check.setPegCode(6);
            } else {
                pieceToast = Toast.makeText(getApplicationContext(), "Press the Check Button", Toast.LENGTH_SHORT);
                pieceToast.show();
            }

            break;

        case R.id.CodeButton:

            String displayCode = "";
            for (int q = 0; q < code.length; q++) {
                displayCode += String.valueOf(code[q]);
            }

            pieceToast = Toast.makeText(getApplicationContext(), displayCode, Toast.LENGTH_SHORT);
            pieceToast.show();


            break;

        case R.id.LineButton:

            b = Full();
            if(b == false){
                pieceToast = Toast.makeText(getApplicationContext(), "Please fill in all available peg slots", Toast.LENGTH_SHORT);
                pieceToast.show();
            }
            else {
                Peg.pegRelease();
                win = Check.CheckGame(code);
                pins = Check.ReturnPins();
                drawPin(pins);
                //toastPins(pins);
                if (win == true) {


                    final View bubble = v;
                    mp = MediaPlayer.create(this, R.raw.win_noise);
                    mp.start();
                    String message = getString(R.string.dialog_text);
                    AlertDialog.Builder alertDialog = new AlertDialog.Builder(this);
                    alertDialog.setTitle("Congratulations! You win");
                    alertDialog.setMessage(message);
                    alertDialog.setPositiveButton("Play", new DialogInterface.OnClickListener() {
                        public void onClick(DialogInterface dialog, int which) {
                            //Intent intent = new Intent(bubble.getContext(), MainActivity.class);
                            //startActivityForResult(intent, 0);
                            Intent mIntent = getIntent();
                            finish();
                            startActivity(mIntent);
                            stopMedia();
                        }
                    });
                    alertDialog.setNegativeButton("Menu", new DialogInterface.OnClickListener() {
                        public void onClick(DialogInterface dialog, int which) {
                            finish();
                            stopMedia();
                        }
                    });
                    alertDialog.show();
                }
            }

            break;

        default:
            break;
    }

}
 
Figured out the issue!!! I hadn't set up anything to default a 6 Peg 4 or 5 colour system to automatically allow duplicates. Thanks for the help, really made me comb through the code again.
 
You must log in or register to reply here.
Back
Top Bottom