You are not making sense.
You claim social programs are unconstitutional because they take from the productive and give to the unproductive.
But that's true of every federal program.
You seem to be confusing government programs with rights.
You are both right. The military is a constitutional mandate, but national defense is not a "right" as per the constitution. If it was a "right", it would be listed in the Bill of Rights.
General Welfare is a constitutional mandate, but not a "right" as per the constitution.
Rights, by definition, are things that you can do (as long as they don't infringe on the rights of others).
For instance, you have a right to own a firearm. However, a convicted felon owning a firearm has a high tendency to infringe the rights of others, so that is not allowed.
No rights involve having government, or private citizens, provide you with a service.
The only right that could be arguable is legal representation. Government provides lawyers to fulfill your "Right" to legal counsel.
However, on closer inspection, it is not a right to have the government provide legal counsel. It is a right against the government convicting you without legal counsel.
The government provides you with legal counsel (if you cannot provide it for yourself), because it CANNOT convict you of a crime otherwise.
For further evidence... you are only provided legal representation when you are the defendant in a criminal trial. If you are being sued, you are not provided representation. If you are suing someone you are not provided representation.
---------------------------------------------------------------------------
So, in summary... you are both right.
Health Care, Welfare, National Defense and Social Security are NOT rights, and NEVER could be.
However, the fact that they are NOT rights doesn't make them unconstitutional either.