• After 15+ years, we've made a big change: Android Forums is now Early Bird Club. Learn more here.

Apps My listview items get repeat when it scrolls down . Please solve this issue!!

A

ashish1427

Lurker
  1. // This is my JobListAdapter class

  3. package com.example.hellotest.adapters;

  5. import java.text.ParseException;
  6. import java.text.SimpleDateFormat;
  7. import java.util.List;
  8. import java.util.Locale;

  10. import android.content.Context;
  11. import android.view.LayoutInflater;
  12. import android.view.View;
  13. import android.view.ViewGroup;
  14. import android.widget.BaseAdapter;
  15. import android.widget.TextView;

  17. import com.example.hellotest.R;
  18. import com.example.hellotest.model.Job;

  20. public class JobListAdapter extends BaseAdapter {

  22. private LayoutInflater mInflater ;
  23. private List<Job> mJobs;
  24. private SimpleDateFormat mDateFormat;
  25. private SimpleDateFormat mInputFormat;
  26. private String mPosterPrefix;
  28. public JobListAdapter(Context context) {
  29. mInflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
  30. mDateFormat = new SimpleDateFormat("dd MMMM yyyy", Locale.US);
  31. mInputFormat = new SimpleDateFormat("yyyy-MM-dd hh:mm:ss", Locale.US);
  32. mPosterPrefix = context.getString(R.string.job_posted_by);
  33. }
  35. public void setJobList(List<Job> jobs) {
  36. mJobs = jobs;
  37. }
  39. @override
  40. public int getCount() {
  41. if(null != mJobs) {
  42. //mJobs.clear();
  43. return mJobs.size();
  44. }
  45. return 0;
  46. }

  48. @override
  49. public Object getItem(int position) {
  50. return mJobs.get(position);
  51. }

  53. @override
  54. public long getItemId(int position) {
  55. return mJobs.get(position).getId();
  56. }
  57. // There might be some problem here in this function i googled it but doesnot find anything worth.
  58. @override
  59. public View getView(int position, View convertView, ViewGroup parent) {
  60. ViewHolder holder;
  61. if(null == convertView) {
  62. convertView = mInflater.inflate(R.layout.job_list_row, null);
  63. holder = new ViewHolder();
  64. holder.created = (TextView) convertView.findViewById(R.id.job_listing_date);
  65. holder.location = (TextView) convertView.findViewById(R.id.job_listing_location);
  66. holder.title = (TextView) convertView.findViewById(R.id.job_listing_title);
  67. holder.experience = (TextView) convertView.findViewById(R.id.job_listing_experience);
  68. holder.poster = (TextView) convertView.findViewById(R.id.job_listing_posted_by);
  69. convertView.setTag(holder);
  70. }
  72. else
  73. {
  74. holder = (ViewHolder) convertView.getTag();
  75. }
  79. updateRow(holder, mJobs.get(position));
  80. //notifyDataSetChanged();
  81. return convertView;
  82. }
  84. private void updateRow(ViewHolder holder, Job job) {
  85. holder.title.setText(job.getTitle());
  86. int id = job.isPremium() ? R.drawable.icon_premium : 0;
  87. holder.created.setText(getDate(job.getCreated()));
  88. holder.created.setCompoundDrawablesWithIntrinsicBounds(0, 0, id, 0);
  89. holder.experience.setText(job.getExperience());
  90. holder.location.setText(job.getLocation());
  91. holder.poster.setText(mPosterPrefix + job.getPoster());
  92. }

  94. private CharSequence getDate(String created) {
  95. try {
  96. return mDateFormat.format(mInputFormat.parse(created));
  97. } catch (ParseException e) {
  98. e.printStackTrace();
  99. }
  100. return created;
  101. }

  103. private static class ViewHolder {
  104. TextView created;
  105. TextView title;
  106. TextView location;
  107. TextView experience;
  108. TextView poster;
  109. }

  111. }

  113. //this is my JobListingFragment class

  115. package com.example.hellotest;
  116. import java.util.List;
  117. import android.app.Activity;
  118. import android.content.Intent;
  119. import android.os.Bundle;
  120. import android.support.v4.app.Fragment;
  121. import android.text.TextUtils;
  122. import android.view.LayoutInflater;
  123. import android.view.View;
  124. import android.view.View.OnClickListener;
  125. import android.view.ViewGroup;
  126. import android.widget.AbsListView;
  127. import android.widget.AbsListView.OnScrollListener;
  128. import android.widget.AdapterView;
  129. import android.widget.AdapterView.OnItemClickListener;
  130. import android.widget.ListView;
  131. import android.widget.ProgressBar;
  132. import android.widget.TextView;
  133. import android.widget.Toast;
  134. import com.android.volley.Request.Method;
  135. import com.android.volley.RequestQueue;
  136. import com.android.volley.Response;
  137. import com.android.volley.Response.ErrorListener;
  138. import com.android.volley.Response.Listener;
  139. import com.android.volley.VolleyError;
  140. import com.android.volley.toolbox.Volley;
  141. import com.example.hellotest.R;
  142. import com.example.hellotest.adapters.JobListAdapter;
  143. import com.example.hellotest.config.Constant;
  144. import com.example.hellotest.io.CookieStringRequest;
  145. import com.example.hellotest.io.json.JobsProcessor;
  146. import com.example.hellotest.model.Job;
  147. import com.example.hellotest.model.JobList;
  148. import com.example.hellotest.model.Pagination;
  149. import com.example.hellotest.tasks.JsonParserTask;
  150. import com.example.hellotest.tasks.JsonParsingListener;
  151. import com.example.hellotest.util.AccountUtils;
  152. import com.example.hellotest.util.Log;

  154. public class JobListingFragment extends Fragment {

  156. public static final String ARG_URL = "argument_url";
  157. public static final String ARG_IS_FILTER_ON = "argument_is_filtered";
  158. public static final String ARG_IS_DEFAULT_JOB_LIST = "argument_is_default_job_list";
  159. public static final String ARG_EMPTY_MESSAGE = "argument_empty_message";

  161. protected static final int REQUEST_EXPERIENCE = 0x11;
  162. protected static final int REQUEST_LOCATION = 0x12;
  163. private ListView mJobsList;
  164. private TextView mMessageView;
  165. private JobListAdapter mAdapter;
  166. private List<Job> mJobs;
  167. private Pagination mPagination;
  168. private boolean mIsFetching;
  169. private boolean mIsDefaultList;
  170. private boolean mIsFilterOn;
  171. private String mUrl;
  172. private String mLocId;
  173. private int mExperienceId = -1;
  174. private ProgressBar mFooterProgress;
  175. private Log mLogger = new Log(JobListingFragment.class);
  176. private Object mRequestTag = new Object();
  177. private RequestQueue mRequestQueue;

  179. @override
  180. public void onCreate(Bundle savedInstanceState) {
  181. super.onCreate(savedInstanceState);
  182. mAdapter = new JobListAdapter(getActivity());
  183. if (null != savedInstanceState) {
  184. getState(savedInstanceState);
  185. } else {
  186. getState(getArguments());
  187. }
  188. // init();
  189. }
  191. @override
  192. public void onAttach(Activity activity) {
  193. super.onAttach(activity);
  194. mRequestQueue = Volley.newRequestQueue(getActivity());
  195. }
  197. @override
  198. public void onDetach() {
  199. mRequestQueue.cancelAll(mRequestTag);
  200. super.onDetach();
  201. }
  203. @override
  204. public void onResume() {
  205. init();
  206. super.onResume();
  207. }

  209. private void getState(Bundle bundle) {
  210. mUrl = bundle.getString(ARG_URL);
  211. mIsFilterOn = bundle.getBoolean(ARG_IS_FILTER_ON);
  212. mIsDefaultList = bundle.getBoolean(ARG_IS_DEFAULT_JOB_LIST);
  213. }

  215. @override
  216. public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)
  217. {
  218. View view = inflater.inflate(R.layout.fragment_job_listing, null);
  219. mJobsList = (ListView) view.findViewById(R.id.job_list);
  220. mMessageView = (TextView) view.findViewById(R.id.job_listing_message);
  221. return view;
  222. }

  224. @override
  225. public void onViewCreated(View view, Bundle savedInstanceState) {
  226. View footer = getLayoutInflater(savedInstanceState).inflate(R.layout.paginated_list_footer, null);
  227. mFooterProgress = (ProgressBar) footer.findViewById(R.id.footer_progress);
  228. if (!mIsFilterOn) {
  229. view.findViewById(R.id.job_listing_filter_container).setVisibility(View.GONE);
  230. } else {
  231. view.findViewById(R.id.job_listing_experience).setOnClickListener(mOnClickListener);
  232. view.findViewById(R.id.job_listing_location).setOnClickListener(mOnClickListener);
  233. }
  234. mJobsList.addFooterView(footer);
  235. mJobsList.setAdapter(mAdapter);
  236. mJobsList.setOnScrollListener(mOnScrollListener);
  237. mJobsList.setOnItemClickListener(mOnItemClickListener);
  238. super.onViewCreated(view, savedInstanceState);
  239. }

  241. @override
  242. public void onSaveInstanceState(Bundle outState) {
  243. outState.putString(ARG_URL, mUrl);
  244. outState.putBoolean(ARG_IS_FILTER_ON, mIsFilterOn);
  245. outState.putBoolean(ARG_IS_DEFAULT_JOB_LIST, mIsDefaultList);
  246. super.onSaveInstanceState(outState);
  247. }

  249. public void startAfresh(String url, boolean isPaginated) {
  250. mLogger.d("old fragment reused");
  251. mIsFilterOn = true;
  252. mUrl = url;
  253. reset();
  254. init();
  255. }

  257. private void init() {
  258. mLocId = AccountUtils.getLocationFilter();
  259. mExperienceId = AccountUtils.getExperienceFilter();
  260. String url = getUrl(1);
  261. fetchJobs(url);
  263. }

  265. private void reset() {
  266. mJobs = null;
  267. mPagination = null;
  268. mAdapter.setJobList(null);
  269. mAdapter.notifyDataSetChanged();
  270. }

  272. private String getUrl(int pageNumber) {
  273. String appender = "";
  274. if (mIsFilterOn) {
  275. if (null != mLocId || -1 < mExperienceId) {
  276. if (null != mLocId) {
  277. appender += "/loc-" + mLocId;
  278. } else {
  279. appender += "/loc-" + 0;
  280. }

  282. if (-1 < mExperienceId) {
  283. appender += "/exp-" + mExperienceId;
  284. } else {
  285. appender += "/exp-" + 0;
  286. }
  287. }
  288. }
  289. String url = mUrl + appender + "/pg-" + pageNumber;
  290. if (mIsDefaultList && AccountUtils.isLoggedIn()) {
  291. url += "?" + Constant.MAP_COOKIE_KEY + "=" + AccountUtils.getCookie();
  292. }
  293. return url;
  294. }

  296. private void fetchJobs(String url) {
  297. mIsFetching = true;
  298. mLogger.d("url :" + url);
  299. int method = mIsDefaultList ? Method.GET : Method.POST;
  300. CookieStringRequest request = new CookieStringRequest(method, url, mListener, mErrorListener);
  301. request.setTag(mRequestTag);
  302. mRequestQueue.add(request);
  303. }

  305. private Response.Listener<String> mListener = new Listener<String>() {

  307. @override
  308. public void onResponse(String response) {
  309. mLogger.d("response :" + response);
  310. JsonParserTask<JobList> jsonTask = new JsonParserTask<JobList>(new JobsProcessor());
  311. jsonTask.setListener(mJsonListener);
  312. jsonTask.execute(response);

  314. }
  315. };

  317. private Response.ErrorListener mErrorListener = new ErrorListener() {

  319. @override
  320. public void onErrorResponse(VolleyError error) {
  321. mIsFetching = false;
  322. Toast.makeText(getActivity(), R.string.network_error, Toast.LENGTH_LONG).show();
  323. }
  324. };

  326. private JsonParsingListener<JobList> mJsonListener = new JsonParsingListener<JobList>() {

  328. @override
  329. public void onSuccess(JobList result) {
  330. if (null == mPagination) {
  331. mPagination = result.getPagination();
  332. mPagination.setCurrentPage(0);
  333. if(null == result.getJobs() || 0 == result.getJobs().size()) {
  334. mMessageView.setText(getArguments().getString(ARG_EMPTY_MESSAGE));
  335. mMessageView.setVisibility(View.VISIBLE);
  336. } else {
  337. mMessageView.setVisibility(View.GONE);
  338. }
  339. } else {
  340. mPagination.updateData(result.getPagination());
  341. }

  343. if (null != mJobs) {
  344. //mJobs.add(result.)
  345. //mJobs.clear();
  346. mJobs.retainAll(mJobs);
  347. mJobs.addAll(result.getJobs());
  348. //mJobs.clear();
  349. } else {
  350. mJobs = result.getJobs();
  351. }
  352. mAdapter.setJobList(mJobs);
  353. mAdapter.notifyDataSetChanged();
  354. mIsFetching = false;
  355. }

  357. @override
  358. public void onFailure(Exception e) {
  359. Toast.makeText(getActivity(), "Unable to process response", Toast.LENGTH_LONG).show();
  360. mIsFetching = false;
  361. }
  362. };

  364. private OnItemClickListener mOnItemClickListener = new OnItemClickListener() {

  366. @override
  367. public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
  368. Job job = (Job) mAdapter.getItem(position);
  369. Intent intent = new Intent(getActivity(), JobDetailsActivity.class);
  370. intent.putExtra(JobDetailsActivity.EXTRA_JOB, job);
  371. startActivity(intent);
  372. }
  373. };
  374. // this function may have some biug because when i scrolls down the list repeats . please suggest the solution
  375. private OnScrollListener mOnScrollListener = new OnScrollListener() {

  377. @override
  378. public void onScrollStateChanged(AbsListView view, int scrollState) {

  380. }

  382. @override
  383. public void onScroll(AbsListView view, int firstVisibleItem, int visibleItemCount, int totalItemCount) {
  384. boolean loadMore = firstVisibleItem + visibleItemCount >= totalItemCount;
  385. if (loadMore && totalItemCount > 0 && null != mPagination) {
  386. boolean isLastPage = mPagination.getCurrentPage() >= mPagination.getTotalPages();
  387. if (isLastPage) {
  388. mFooterProgress.setVisibility(View.GONE);
  389. }
  390. if (!mIsFetching && !isLastPage) {
  391. fetchJobs(getUrl(mPagination.getCurrentPage()+1));
  392. }
  393. }
  394. }
  395. };

  397. public void onActivityResult(int requestCode, int resultCode, Intent data) {
  398. if (Activity.RESULT_OK == resultCode) {
  399. switch (requestCode) {
  400. case REQUEST_EXPERIENCE:
  401. onExperienceSelection(data);
  402. break;

  404. case REQUEST_LOCATION:
  405. onLocationSelection(data);
  406. break;
  407. }
  408. }
  409. }

  411. private void onLocationSelection(Intent data) {
  412. int ids[] = data.getIntArrayExtra(PopupActivity.RESULT_ID);
  413. String idStrs = "";
  414. for (int id : ids) {
  415. idStrs += "_" + id;
  416. }
  417. if (TextUtils.isEmpty(idStrs)) {
  418. mLocId = null;
  419. } else {
  420. mLocId = idStrs.substring(1);
  421. }
  422. AccountUtils.setLocationFilter(mLocId);
  423. reset();
  424. fetchJobs(getUrl(1));

  426. }

  428. private void onExperienceSelection(Intent data) {
  429. mExperienceId = data.getIntExtra(PopupActivity.RESULT_ID, -1);
  430. AccountUtils.setExperienceFilter(mExperienceId);
  431. mLogger.d("experince id :" + mExperienceId);
  432. reset();
  433. fetchJobs(getUrl(1));
  434. };

  436. private OnClickListener mOnClickListener = new OnClickListener() {

  438. @override
  439. public void onClick(View v) {
  440. Intent intent = new Intent(getActivity(), PopupActivity.class);
  441. switch (v.getId()) {
  442. case R.id.job_listing_experience:
  443. intent.putExtra(PopupActivity.EXTRA_DATA_TYPE, PopupActivity.DATA_TYPE_FILTER_EXPERIENCE);
  444. intent.putExtra(PopupActivity.EXTRA_SELECTED_ID, mExperienceId);
  445. startActivityForResult(intent, REQUEST_EXPERIENCE);
  446. break;

  448. case R.id.job_listing_location:
  449. intent.putExtra(PopupActivity.EXTRA_DATA_TYPE, PopupActivity.DATA_TYPE_FILTER_LOCATION);
  450. intent.putExtra(PopupActivity.EXTRA_IS_MULTIPLE_MODE_ON, true);
  451. passLocationIds(intent);
  452. startActivityForResult(intent, REQUEST_LOCATION);
  453. break;
  454. }

  456. }
  457. };

  459. protected void passLocationIds(Intent intent) {
  460. if(null != mLocId) {
  461. String[] str = mLocId.split("_");
  462. int ids[] = new int[str.length];
  463. for(int i = 0; i < str.length; i++) {
  464. ids = Integer.parseInt(str.trim());
    [*] }
    [*] intent.putExtra(PopupActivity.EXTRA_SELECTED_ID, ids);
    [*] }
    [*]
    [*] }
    [*]}
 
You must log in or register to reply here.
Back
Top Bottom