• After 15+ years, we've made a big change: Android Forums is now Early Bird Club. Learn more here.

Root [Discussion - Developers _ONLY_] Building ICS from source (Isaac's github).

Hey Isaac,

First of all, thank you for everything you've done for this phone and this community. I really appreciate the work and I'll be throwing you a donation sometime after the Christmas expenses settle.

Look back at the road to ICS thread, I saw that you got the radio partially working, but it doesn't look like anyone who has built from your github (myself included) got a working radio. Any idea what happened to that? Were the changes not pushed or did somthing new break it?

A working radio (even partially) would be a huge step towards a usable ROM.

I honestly don't know. Everything keeps changing from every side and it's difficult for me to keep up with everything. To make matters worse, I haven't found any documentation on 4.0. As far as my changes go, I haven't done anything that would cause all these regressions. However, the 4.0.3 merge was a massive one and a lot of things got changed. I believe 4.0.1 was technically a "developer's" release. It was a bad idea for me to start with that.

Another thing that baffles me is why software rendering refuses to work on the Triumph. (I understand why HWA doesn't work). The Triumph is a fairly typical msm7x30 device (with an equally common GPU - Adreno 205). I'm not doing anything differently than any other msm7x30 device and yet it refuses to cooperate.

EDIT: I forgot to mention I pushed a kernel to my repo: https://github.com/ikarosdev/androi...mmit/622f58441395850f0963bfd6168374656091f4bc

It's basically the same kernel minus the HW3D crap. I just want to see if I can get the UI to come back up again (i.e. get the ROM in a bootable state again).
 
Got this while makign the build after redoing my repo the last couple of days. I think I got all of the extra changes you did but perhaps I missed something:

Code:
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::reserved'
target thumb C++: hwcomposer.msm7x30 <= hardware/qcom/display/libhwcomposer/hwcomposer.cpp
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::dso'
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::reserved'
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'bool isValidDestination(const framebuffer_device_t*, const hwc_rect_t&)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'int getLayersNotUpdatingCount(const hwc_layer_list_t*)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:799: error: 'HWC_LAYER_NOT_UPDATING' was not declared in this scope
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'int drawLayerUsingCopybit(hwc_composer_device_t*, hwc_layer_t*, void*, void*)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:1059: error: 'eglGetRenderBufferANDROID' was not declared in this scope
make: *** [out/target/product/triumph/obj/SHARED_LIBRARIES/hwcomposer.msm7x30_intermediates/hwcomposer.o] Error 1
make: *** Waiting for unfinished jobs....
 
Finally got set up dual boot with Ubuntu running on a dual core 2.0Ghz laptop. Nice upgrade from the old Dell 700m. Maybe not high end, but blazing fast compared to what I've been using for the last 7 years.

Synced last night & tried running a build this morning.
After a half hour (not 6 hours as on the Dell) ended up bombing on audio.

make: *** No rule to make target `out/target/product/triumph/obj/lib/libaudio.so', needed by `out/target/product/triumph/obj/SHARED_LIBRARIES/audio.primary.triumph_intermediates/LINKED/audio.primary.triumph.so'. Stop.
make: *** Waiting for unfinished jobs....
target thumb C: audio.primary.default <= hardware/libhardware/modules/audio/audio_hw.c

Still digging thru files trying to figure out what defines what & how it's all coming together. Learning as I go.
Any tips on where to go for this one?
 
I honestly don't know. Everything keeps changing from every side and it's difficult for me to keep up with everything. To make matters worse, I haven't found any documentation on 4.0. As far as my changes go, I haven't done anything that would cause all these regressions. However, the 4.0.3 merge was a massive one and a lot of things got changed. I believe 4.0.1 was technically a "developer's" release. It was a bad idea for me to start with that.

Another thing that baffles me is why software rendering refuses to work on the Triumph. (I understand why HWA doesn't work). The Triumph is a fairly typical msm7x30 device (with an equally common GPU - Adreno 205). I'm not doing anything differently than any other msm7x30 device and yet it refuses to cooperate.

EDIT: I forgot to mention I pushed a kernel to my repo: https://github.com/ikarosdev/androi...mmit/622f58441395850f0963bfd6168374656091f4bc

It's basically the same kernel minus the HW3D crap. I just want to see if I can get the UI to come back up again (i.e. get the ROM in a bootable state again).

Well maybe starting over fresh would be good?
 
Finally got set up dual boot with Ubuntu running on a dual core 2.0Ghz laptop. Nice upgrade from the old Dell 700m. Maybe not high end, but blazing fast compared to what I've been using for the last 7 years.

Synced last night & tried running a build this morning.
After a half hour (not 6 hours as on the Dell) ended up bombing on audio.

make: *** No rule to make target `out/target/product/triumph/obj/lib/libaudio.so', needed by `out/target/product/triumph/obj/SHARED_LIBRARIES/audio.primary.triumph_intermediates/LINKED/audio.primary.triumph.so'. Stop.
make: *** Waiting for unfinished jobs....
target thumb C: audio.primary.default <= hardware/libhardware/modules/audio/audio_hw.c

Still digging thru files trying to figure out what defines what & how it's all coming together. Learning as I go.
Any tips on where to go for this one?

That's one of the proprietary files. You need to rerun that extract-files.sh again.
 
I was replying back to you. The error you posted above you should be fixed after my recent commits.

EDIT: This post: http://androidforums.com/3699698-post253.html

Ok, thanks! Will do that and report back.

Edit: Ok, I had to manually apply this commit to get past the first error:

https://github.com/ikarosdev/android_hardware_qcom_display/commit/4f80294ab7a28bd309120721fa717ea6f512e65f

For some reason, it didn't come down on the repo sync. The build now stops here:

Code:
target thumb C++: camera.goldfish <= development/tools/emulator/system/camera/JpegCompressor.cpp
target thumb C: gps.goldfish <= development/tools/emulator/system/gps/gps_qemu.c
development/tools/emulator/system/gps/gps_qemu.c:47:1: warning: "D" redefined
In file included from hardware/libhardware/include/hardware/qemud.h:21,
from development/tools/emulator/system/gps/gps_qemu.c:37:
hardware/libhardware/include/hardware/qemu_pipe.h:29:1: warning: this is the location of the previous definition
development/tools/emulator/system/gps/gps_qemu.c:903: warning: initialization from incompatible pointer type
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/gralloc.cpp
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'hw_module_t::reserved'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'gralloc_module_t::perform'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'gralloc_module_t::reserved_proc'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::pmem_master'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::pmem_master_base'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::info'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::finfo'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::xdpi'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::ydpi'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::fps'
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/framebuffer.cpp
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/mapper.cpp
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/framebuffer.cpp
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/gpu.cpp
hardware/qcom/display/libgralloc/framebuffer.cpp: In function 'int mapFrameBufferLocked(private_module_t*)':
hardware/qcom/display/libgralloc/framebuffer.cpp:956: warning: comparison of unsigned expression < 0 is always false
hardware/qcom/display/libgralloc/framebuffer.cpp:957: warning: comparison between signed and unsigned integer expressions
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/gralloc.cpp
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::info'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::finfo'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::xdpi'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::ydpi'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::fps'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::swapInterval'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::disp'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::currentIdx'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::avail'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::qlock'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::qpost'
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/mapper.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/ashmemalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/pmemalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/pmem_bestfit_alloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/alloc_controller.cpp
target thumb C++: libgenlock <= hardware/qcom/display/libgenlock/genlock.cpp
target thumb C++: hwcomposer.default <= hardware/libhardware/modules/hwcomposer/hwcomposer.cpp
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::reserved'
target thumb C++: hwcomposer.msm7x30 <= hardware/qcom/display/libhwcomposer/hwcomposer.cpp
target thumb C++: liboverlay <= hardware/qcom/display/liboverlay/overlayLib.cpp
hardware/qcom/display/liboverlay/overlayLib.cpp:121:1: warning: "LOG_TAG" redefined
In file included from hardware/qcom/display/liboverlay/overlayLib.h:21,
from hardware/qcom/display/liboverlay/overlayLib.cpp:18:
system/core/include/cutils/log.h:68:1: warning: this is the location of the previous definition
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::dso'
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::reserved'
hardware/qcom/display/liboverlay/overlayLib.cpp: In member function 'bool overlay::OverlayControlChannel::setPosition(int, int, uint32_t, uint32_t)':
hardware/qcom/display/liboverlay/overlayLib.cpp:1164: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1165: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1171: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1171: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'bool isValidDestination(const framebuffer_device_t*, const hwc_rect_t&)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp: In member function 'bool overlay::OverlayControlChannel::setTransform(int, bool)':
hardware/qcom/display/liboverlay/overlayLib.cpp:1243: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'int drawLayerUsingCopybit(hwc_composer_device_t*, hwc_layer_t*, void*, void*)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:1059: error: 'eglGetRenderBufferANDROID' was not declared in this scope
make: *** [out/target/product/triumph/obj/SHARED_LIBRARIES/hwcomposer.msm7x30_intermediates/hwcomposer.o] Error 1
make: *** Waiting for unfinished jobs....
 
Ok, thanks! Will do that and report back.

Edit: Ok, I had to manually apply this commit to get past the first error:

https://github.com/ikarosdev/android_hardware_qcom_display/commit/4f80294ab7a28bd309120721fa717ea6f512e65f

For some reason, it didn't come down on the repo sync. The build now stops here:

Code:
target thumb C++: camera.goldfish <= development/tools/emulator/system/camera/JpegCompressor.cpp
target thumb C: gps.goldfish <= development/tools/emulator/system/gps/gps_qemu.c
development/tools/emulator/system/gps/gps_qemu.c:47:1: warning: "D" redefined
In file included from hardware/libhardware/include/hardware/qemud.h:21,
from development/tools/emulator/system/gps/gps_qemu.c:37:
hardware/libhardware/include/hardware/qemu_pipe.h:29:1: warning: this is the location of the previous definition
development/tools/emulator/system/gps/gps_qemu.c:903: warning: initialization from incompatible pointer type
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/gralloc.cpp
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'hw_module_t::reserved'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'gralloc_module_t::perform'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'gralloc_module_t::reserved_proc'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::pmem_master'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::pmem_master_base'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::info'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::finfo'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::xdpi'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::ydpi'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::fps'
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/framebuffer.cpp
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/mapper.cpp
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/framebuffer.cpp
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/gpu.cpp
hardware/qcom/display/libgralloc/framebuffer.cpp: In function 'int mapFrameBufferLocked(private_module_t*)':
hardware/qcom/display/libgralloc/framebuffer.cpp:956: warning: comparison of unsigned expression < 0 is always false
hardware/qcom/display/libgralloc/framebuffer.cpp:957: warning: comparison between signed and unsigned integer expressions
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/gralloc.cpp
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::info'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::finfo'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::xdpi'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::ydpi'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::fps'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::swapInterval'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::disp'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::currentIdx'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::avail'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::qlock'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::qpost'
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/mapper.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/ashmemalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/pmemalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/pmem_bestfit_alloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/alloc_controller.cpp
target thumb C++: libgenlock <= hardware/qcom/display/libgenlock/genlock.cpp
target thumb C++: hwcomposer.default <= hardware/libhardware/modules/hwcomposer/hwcomposer.cpp
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::reserved'
target thumb C++: hwcomposer.msm7x30 <= hardware/qcom/display/libhwcomposer/hwcomposer.cpp
target thumb C++: liboverlay <= hardware/qcom/display/liboverlay/overlayLib.cpp
hardware/qcom/display/liboverlay/overlayLib.cpp:121:1: warning: "LOG_TAG" redefined
In file included from hardware/qcom/display/liboverlay/overlayLib.h:21,
from hardware/qcom/display/liboverlay/overlayLib.cpp:18:
system/core/include/cutils/log.h:68:1: warning: this is the location of the previous definition
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::dso'
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::reserved'
hardware/qcom/display/liboverlay/overlayLib.cpp: In member function 'bool overlay::OverlayControlChannel::setPosition(int, int, uint32_t, uint32_t)':
hardware/qcom/display/liboverlay/overlayLib.cpp:1164: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1165: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1171: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1171: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'bool isValidDestination(const framebuffer_device_t*, const hwc_rect_t&)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp: In member function 'bool overlay::OverlayControlChannel::setTransform(int, bool)':
hardware/qcom/display/liboverlay/overlayLib.cpp:1243: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'int drawLayerUsingCopybit(hwc_composer_device_t*, hwc_layer_t*, void*, void*)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:1059: error: 'eglGetRenderBufferANDROID' was not declared in this scope
make: *** [out/target/product/triumph/obj/SHARED_LIBRARIES/hwcomposer.msm7x30_intermediates/hwcomposer.o] Error 1
make: *** Waiting for unfinished jobs....

I got the same error. :/
 
Ok, thanks! Will do that and report back.

Edit: Ok, I had to manually apply this commit to get past the first error:

https://github.com/ikarosdev/android_hardware_qcom_display/commit/4f80294ab7a28bd309120721fa717ea6f512e65f

For some reason, it didn't come down on the repo sync. The build now stops here:

Code:
target thumb C++: camera.goldfish <= development/tools/emulator/system/camera/JpegCompressor.cpp
target thumb C: gps.goldfish <= development/tools/emulator/system/gps/gps_qemu.c
development/tools/emulator/system/gps/gps_qemu.c:47:1: warning: "D" redefined
In file included from hardware/libhardware/include/hardware/qemud.h:21,
from development/tools/emulator/system/gps/gps_qemu.c:37:
hardware/libhardware/include/hardware/qemu_pipe.h:29:1: warning: this is the location of the previous definition
development/tools/emulator/system/gps/gps_qemu.c:903: warning: initialization from incompatible pointer type
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/gralloc.cpp
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'hw_module_t::reserved'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'gralloc_module_t::perform'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'gralloc_module_t::reserved_proc'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::pmem_master'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::pmem_master_base'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::info'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::finfo'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::xdpi'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::ydpi'
hardware/libhardware/modules/gralloc/gralloc.cpp:100: warning: missing initializer for member 'private_module_t::fps'
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/framebuffer.cpp
target thumb C++: gralloc.default <= hardware/libhardware/modules/gralloc/mapper.cpp
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/framebuffer.cpp
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/gpu.cpp
hardware/qcom/display/libgralloc/framebuffer.cpp: In function 'int mapFrameBufferLocked(private_module_t*)':
hardware/qcom/display/libgralloc/framebuffer.cpp:956: warning: comparison of unsigned expression < 0 is always false
hardware/qcom/display/libgralloc/framebuffer.cpp:957: warning: comparison between signed and unsigned integer expressions
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/gralloc.cpp
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::info'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::finfo'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::xdpi'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::ydpi'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::fps'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::swapInterval'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::disp'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::currentIdx'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::avail'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::qlock'
hardware/qcom/display/libgralloc/gralloc.cpp:94: warning: missing initializer for member 'private_module_t::qpost'
target thumb C++: gralloc.msm7x30 <= hardware/qcom/display/libgralloc/mapper.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/ashmemalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/pmemalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/pmem_bestfit_alloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/libgralloc/alloc_controller.cpp
target thumb C++: libgenlock <= hardware/qcom/display/libgenlock/genlock.cpp
target thumb C++: hwcomposer.default <= hardware/libhardware/modules/hwcomposer/hwcomposer.cpp
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::dso'
hardware/libhardware/modules/hwcomposer/hwcomposer.cpp:53: warning: missing initializer for member 'hw_module_t::reserved'
target thumb C++: hwcomposer.msm7x30 <= hardware/qcom/display/libhwcomposer/hwcomposer.cpp
target thumb C++: liboverlay <= hardware/qcom/display/liboverlay/overlayLib.cpp
hardware/qcom/display/liboverlay/overlayLib.cpp:121:1: warning: "LOG_TAG" redefined
In file included from hardware/qcom/display/liboverlay/overlayLib.h:21,
from hardware/qcom/display/liboverlay/overlayLib.cpp:18:
system/core/include/cutils/log.h:68:1: warning: this is the location of the previous definition
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::dso'
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:146: warning: missing initializer for member 'hw_module_t::reserved'
hardware/qcom/display/liboverlay/overlayLib.cpp: In member function 'bool overlay::OverlayControlChannel::setPosition(int, int, uint32_t, uint32_t)':
hardware/qcom/display/liboverlay/overlayLib.cpp:1164: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1165: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1171: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp:1171: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'bool isValidDestination(const framebuffer_device_t*, const hwc_rect_t&)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:728: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/liboverlay/overlayLib.cpp: In member function 'bool overlay::OverlayControlChannel::setTransform(int, bool)':
hardware/qcom/display/liboverlay/overlayLib.cpp:1243: warning: comparison between signed and unsigned integer expressions
hardware/qcom/display/libhwcomposer/hwcomposer.cpp: In function 'int drawLayerUsingCopybit(hwc_composer_device_t*, hwc_layer_t*, void*, void*)':
hardware/qcom/display/libhwcomposer/hwcomposer.cpp:1059: error: 'eglGetRenderBufferANDROID' was not declared in this scope
make: *** [out/target/product/triumph/obj/SHARED_LIBRARIES/hwcomposer.msm7x30_intermediates/hwcomposer.o] Error 1
make: *** Waiting for unfinished jobs....

Check and see if this file (in frameworks/base/opengl/include/EGL/) has the lines you see here: https://github.com/ikarosdev/androi...07ac2c8fa49e4b5dadbbbb7c20d18357f44740#diff-0

I think Git screwed up my commits. I had cherry-picked this commit before it got merged into upstream. So, recently, I reverted it and then merged upstream. The changes are in my local copy of android/frameworks/base, but I think they're missing from yours. If they are, I'll fix it.
 
Check and see if this file (in frameworks/base/opengl/include/EGL/) has the lines you see here: https://github.com/ikarosdev/androi...07ac2c8fa49e4b5dadbbbb7c20d18357f44740#diff-0

I think Git screwed up my commits. I had cherry-picked this commit before it got merged into upstream. So, recently, I reverted it and then merged upstream. The changes are in my local copy of android/frameworks/base, but I think they're missing from yours. If they are, I'll fix it.

Everything that was in that commit are in my local copy.

Edit: I grepped for that function eglGetRenderBufferANDROID and the only places where it is defined in my copy is here:

frameworks/base/opengl/libs/EGL/eglApi.cpp:EGLClientBuffer eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw)
frameworks/base/opengl/libagl/egl.cpp:EGLClientBuffer eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw)

Is one of these functions referenced in a header file that was not included in hwcomposer.cpp?
 
Everything that was in that commit are in my local copy.

Edit: I grepped for that function eglGetRenderBufferANDROID and the only places where it is defined in my copy is here:

frameworks/base/opengl/libs/EGL/eglApi.cpp:EGLClientBuffer eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw)
frameworks/base/opengl/libagl/egl.cpp:EGLClientBuffer eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw)

Is one of these functions referenced in a header file that was not included in hwcomposer.cpp?

In that link I posted above is where it should be. The HWComposer code looks for the function in header found in frameworks/base/opengl/include/EGL/eglext.h.
 
In that link I posted above is where it should be. The HWComposer code looks for the function in header found in frameworks/base/opengl/include/EGL/eglext.h.

You're right. I missed that line when I was reading my grep results. Sorry.

I do have that line in my eglext.h.

However, it's inside this define:

Code:
#ifdef EGL_EGLEXT_PROTOTYPES
EGLAPI EGLClientBuffer EGLAPIENTRY eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw);
#endif

I wonder where this is defined?

Edit: I'm blind. my bad. I see the define now.
 
I see eglGetRenderBufferANDROID in the header which is good.

But I still get Not Declared error. Perhaps the BoardConfig.mk
needs:
BOARD_USES_QCOM_HARDWARE := true

so the precompiler doesn't ignore the def.
 
I see eglGetRenderBufferANDROID in the header which is good.

But I still get Not Declared error. Perhaps the BoardConfig.mk
needs:
BOARD_USES_QCOM_HARDWARE := true

so the precompiler doesn't ignore the def.

That's already there on my copy.
 
I see eglGetRenderBufferANDROID in the header which is good.

But I still get Not Declared error. Perhaps the BoardConfig.mk
needs:
BOARD_USES_QCOM_HARDWARE := true

so the precompiler doesn't ignore the def.

We already have that: https://github.com/ikarosdev/android_device_motorola_triumph/blob/ics/BoardConfig.mk#L52

Try defining the flag globally:

Code:
COMMON_GLOBAL_CFLAGS += -DQCOM_HARDWARE
You can either add the whole line or just "-DQCOM_HARDWARE" where the other flags are being globally defined.
 
That's already there on my copy.

You're right. My bad.

Where is QCOM_HARDWARE supposed to get set?

Code:
#ifdef QCOM_HARDWARE
#ifndef EGL_EGLEXT_PROTOTYPES
#define EGL_EGLEXT_PROTOTYPES 1
#endif

#ifndef EGL_ANDROID_get_render_buffer
#define EGL_ANDROID_get_render_buffer 1
#ifdef EGL_EGLEXT_PROTOTYPES
EGLAPI EGLClientBuffer EGLAPIENTRY eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw);
 
You're right. My bad.

Where is QCOM_HARDWARE supposed to get set?

Code:
#ifdef QCOM_HARDWARE
#ifndef EGL_EGLEXT_PROTOTYPES
#define EGL_EGLEXT_PROTOTYPES 1
#endif

#ifndef EGL_ANDROID_get_render_buffer
#define EGL_ANDROID_get_render_buffer 1
#ifdef EGL_EGLEXT_PROTOTYPES
EGLAPI EGLClientBuffer EGLAPIENTRY eglGetRenderBufferANDROID(EGLDisplay dpy, EGLSurface draw);

See my post right above. Just put it in our BoardConfig makefile.
 
See my post right above. Just put it in our BoardConfig makefile.

Putting that line in the boardconfig seems to have gotten me past that point.

Anyone know why I am getting this build error?
Code:
device/motorola/triumph/overlay/packages/apps/Camera/res/values/config.xml:27: error: Resource at ffc_supportedEffects appears in overlay but not in the base package; use <add-resource> to add.
make: *** [out/target/common/obj/APPS/Camera_intermediates/src/R.stamp] Error 1
make: *** Waiting for unfinished jobs....

That error is occurring because the overlay camera file in device/motorola/triumph/overlay/packages/apps/Camera/res/values/config.xml has values that does not seem to be used anymore in the new camera.apk version.

You can just delete the whole folder

device/motorola/triumph/overlay/packages/apps/Camera

and that should get you past that point.

None of the values in that config.xml file are used anymore. In fact, in the base package for camera.apk, the config.xml file doesn't exist anymore in ics.

Edit: Well, the build completed. But I'm sad to have to say that the build just bootloops and I can't get to the point where I can start logging anything in adb logcat.
 
Putting that line in the boardconfig seems to have gotten me past that point.



That error is occurring because the overlay camera file in device/motorola/triumph/overlay/packages/apps/Camera/res/values/config.xml has values that does not seem to be used anymore in the new camera.apk version.

You can just delete the whole folder

device/motorola/triumph/overlay/packages/apps/Camera

and that should get you past that point.

None of the values in that config.xml file are used anymore. In fact, in the base package for camera.apk, the config.xml file doesn't exist anymore in ics.

Edit: Well, the build completed. But I'm sad to have to say that the build just bootloops and I can't get to the point where I can start logging anything in adb logcat.

I'll make sure to correct the resource file. It's so fun to have things change every day with no knowledge of it (not).

What's the behavior of the bootloop? Do you see the red MOTO logo and then the screen goes black (but still lit) and then it turns off and does the same thing?

Or do you actually see the ICS boot animation and it keeps restarting?

Also, check in the "out/target/product/triumph" folder and look in "system/lib/hw/", is gralloc.msm7x30.so and hwcomposer.msm7x30.so in there?
 
Back
Top Bottom