Thanks a lot for your thoughtful replies.
Why do I want a new phone? My battery is still pretty good, but it's more like to keep the retire the phone before it does die.
If my next phone was not eligible for unlimited Google Photos, one option is have the new phone upload to another cloud source (e.g. I use pcloud), and periodically download it to this old Pixel 2XL where it can upload in unlimited style. That's what I sometimes do with my wife's pictures (from an iPhone)
I guess the headphones isn't a must-have, as I do have the adapter cable. Though I never use it, since I usually use my work Samsung phone or personal Samsung tablet. Or at the gym, I have my bluetooth headset which works with my Pixel 2 XL and would work with any future phone.
Are software updates really that important?
But it would be great to have it all in my next Pixel.
Is Pixel 5a much better then 4a? I'm reading articles about Pixel 6a, but not convinced of it yet. And yes, I'm concerned about 4a being so old (I'm not sure, but more than 2 years?)